Nir Soffer has posted comments on this change. Change subject: Modify reports to metrics ......................................................................
Patch Set 2: (3 comments) Looks good, just few minor issues in the help text. https://gerrit.ovirt.org/#/c/60450/2/lib/vdsm/config.py.in File lib/vdsm/config.py.in: Line 449: ('collector_type', 'statsd', Line 450: 'Metric collector type (supporting statsd or hawkular)'), Line 451: Line 452: ('queue_size', '100', Line 453: 'Number of metrics to queue if collector is not responsive.' This is confusing, better use "metric reports" Line 454: ' When the queue is full, oldest metrics are dropped. Used only' Line 455: ' by hawkular-client collector (default 100).'), Line 456: ]), Line 457: Line 450: 'Metric collector type (supporting statsd or hawkular)'), Line 451: Line 452: ('queue_size', '100', Line 453: 'Number of metrics to queue if collector is not responsive.' Line 454: ' When the queue is full, oldest metrics are dropped. Used only' "metrics reports" Line 455: ' by hawkular-client collector (default 100).'), Line 456: ]), Line 457: Line 458: # Section: [devel] Line 451: Line 452: ('queue_size', '100', Line 453: 'Number of metrics to queue if collector is not responsive.' Line 454: ' When the queue is full, oldest metrics are dropped. Used only' Line 455: ' by hawkular-client collector (default 100).'), reporter was correct, in vdsm we do not collect metrics but report them to the collector. Line 456: ]), Line 457: Line 458: # Section: [devel] Line 459: ('devel', [ -- To view, visit https://gerrit.ovirt.org/60450 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0aa10042b1c50fbdd94ae69053c74b57c3e6f40 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Irit Goihman <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yaniv Kaul <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
