Francesco Romani has posted comments on this change. Change subject: virt: Limit the number of workers in executor ......................................................................
Patch Set 18: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/57754/18/tests/executorTests.py File tests/executorTests.py: Line 177: Line 178: # The other tasks shouldn't be unblocked and executed, let's check Line 179: # things go as expected before proceeding (however we don't want to Line 180: # stop and wait on each of the tasks, the first one is enough) Line 181: self.assertFalse(tasks[0].executed.wait(1)) > I think it's better to give more chance than a fraction of second to potent fair point. Line 182: self.assertEqual([t for t in tasks if t.executed.is_set()], Line 183: [tasks[-1]]) Line 184: Line 185: # Extra tasks are not blocking, they were blocked just by the -- To view, visit https://gerrit.ovirt.org/57754 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba56d91474c6b14a1cfe2db827b6fd61843a1db2 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
