Martin Peřina has posted comments on this change. Change subject: gluster:enforce gluster fencing policies ......................................................................
Patch Set 4: Code-Review-1 I'd really like to move get_gluster_volinfo(), get_gluster_vol_status(), is_gluster_quorum_met() and get_brick() methods into some gluster part of VDSM. Only really necessary part of logic from can_fence_gluster_hosts() may be included in fence related part similarly as we do in host lease checking part (all host lease logic is hidden in _irs.getHostLeaseStatus(). Also please add new parameters of fenceNode verb into lib/api/vdsm-api.yml -- To view, visit https://gerrit.ovirt.org/59600 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c18571209a3a7682a43bd2814b9ee3f0a69c55f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Darshan N <dnara...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org