Nir Soffer has submitted this change and it was merged. Change subject: tests: fix make_block_volume size units ......................................................................
tests: fix make_block_volume size units The utility function make_block_volume takes size in bytes. Unfortunately we were not converting the value properly for LVM (which accepts MB) and the volume metadata (which takes sectors). Further, LVM rounds volume sizes to VG extent granularity (128M). But this detail shouldn't really be known to make_block_volume. Instead, it should pass a value in MB to lvm and then check what size was actually created before proceeding with the metadata creation. Change-Id: Idd582110ffe7c8e6c6dfb94cc90d63770d59e170 Signed-off-by: Adam Litke <ali...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/60408 Reviewed-by: Nir Soffer <nsof...@redhat.com> Continuous-Integration: Jenkins CI --- M tests/storagetestlib.py M tests/storagetestlibTests.py 2 files changed, 36 insertions(+), 5 deletions(-) Approvals: Adam Litke: Verified Nir Soffer: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60408 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd582110ffe7c8e6c6dfb94cc90d63770d59e170 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
