Idan Shaby has posted comments on this change. Change subject: storage: add getDeviceList discard related fields ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/60628/2/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 2012: 'pvsize': str(pvsize), Line 2013: 'serial': dev.get("serial", ""), Line 2014: 'vendorID': dev.get("vendor", ""), Line 2015: 'vgUUID': vguuid, Line 2016: "discard_max_bytes": dev["discard_max_bytes"], > dev.get(name) is correct only when you are ok with sending None when the va Done Line 2017: "discard_zeroes_data": dev["discard_zeroes_data"], Line 2018: } Line 2019: if not checkStatus: Line 2020: devInfo["status"] = "unknown" -- To view, visit https://gerrit.ovirt.org/60628 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ff477dab23a195bd9ce10c36defa35e8a0749d8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yaniv Kaul <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
