Yaniv Bronhaim has posted comments on this change.

Change subject: Send vm info report each sampling interval from HostMonitor
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/59523/3/lib/vdsm/virt/sampling.py
File lib/vdsm/virt/sampling.py:

Line 517:         if log_status:
Line 518:             self._log.debug(
Line 519:                 'sampled timestamp %r elapsed %.3f acquired %r 
domains %s',
Line 520:                 timestamp,  self._stats_cache.clock() - timestamp, 
acquired,
Line 521:                 'all' if fast_path else len(doms))
here I have the _translate(bulk_stats), but not direct access to cif to get the 
normalized values. so what I have is something like:

I'm signing what I plan to send as metric, what as metadata and what I ignore 
(in X). 
please let me know what you think
 
'a16f0a60-0f36-4b19-833e-097ece7d82cc': (I don't have vmname)
{
       'cpu.time': 20198421045L, <- metric
       'cpu.system': 17100000000L,  <- metric
       'cpu.user': 380000000L,      <- metric
                                         
       'state.reason': 1,   X
       'state.state': 1,    X
       
       'vcpu.0.time': 17870000000L, 
       'vcpu.maximum': 16,         <- metadata
       'vcpu.0.state': 1, 
       'vcpu.current': 1,
                                       
       'net.count': 1,             <- metadata
       'net.0.name': 'vnet2',      <- metadata
       'net.0.tx.pkts': 104L,        <- metric
       'net.0.tx.bytes': 6833L,  <- metric
       'net.0.rx.pkts': 576L,    <- metric
       'net.0.rx.drop': 12501L,    <- metric                                
       'net.0.rx.errs': 0L,   <- metric
       'net.0.tx.drop': 0L,     <- metric
       'net.0.tx.errs': 0L,     <- metric
       'net.0.rx.bytes': 134742L,   <- metric
                                         

     
       'block.0.rd.reqs': 0L,    <- metric
       'block.0.name': 'hdc',    <- metadata
       'block.0.wr.reqs': 0L,    <- metric  
       'block.count': 1,         X
       'block.0.rd.times': 0L,   X
       'block.0.physical': 0L,   X 
       'block.0.fl.reqs': 0L,    X
       'block.0.fl.times': 0L},  X
       'block.0.wr.times': 0L,   X
       'block.0.allocation': 0L, X 
       'block.0.wr.bytes': 0L,   <- metric
       'block.0.rd.bytes': 0L,   <- metric
       
       'balloon.current': 1048576L,   X
       'balloon.maximum': 1048576L,   X
Line 522: 
Line 523:     def _get_responsive_doms(self):
Line 524:         vms = self._get_vms()
Line 525:         doms = []


-- 
To view, visit https://gerrit.ovirt.org/59523
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia44f97279e37265deb47ded60557dc98411fb9fc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/admin/lists/[email protected]

Reply via email to