Irit Goihman has posted comments on this change. Change subject: sos report: _importVdsmPylibModule can import all vdsm modules ......................................................................
Patch Set 6: Verified+1 (1 comment) verified importing vdsm.jsonrpcvdscli and vdsm.storage.constants https://gerrit.ovirt.org/#/c/60627/4/vdsm/sos/vdsm.py.in File vdsm/sos/vdsm.py.in: Line 39: parts = fullName.split(".") Line 40: fullName = "" Line 41: for name in parts: Line 42: if fullName: Line 43: fullName += "." > Testing with other modules show that we need the qualified name Done Line 44: fullName += name Line 45: f, path, desc = imp.find_module(name, [search]) Line 46: try: Line 47: module = imp.load_module(fullName, f, path, desc) -- To view, visit https://gerrit.ovirt.org/60627 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab7570d843590ac5fccb669cb13bc758b218655f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <[email protected]> Gerrit-Reviewer: Irit Goihman <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
