Nir Soffer has posted comments on this change. Change subject: storagetestlib: qemu chain verification ......................................................................
Patch Set 3: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/60999/3/tests/storagetestlib.py File tests/storagetestlib.py: Line 267: desc, Line 268: sc.LEGAL_VOL) Line 269: Line 270: Line 271: class ChainVerificationError(Exception): Maybe inherit from AssertionError, so verification failures would be considered as failure (code is broken) instead of an error (test is broken). Line 272: pass Line 273: Line 274: Line 275: def qemu_pattern_write(path, format, offset='512', len='1k', pattern=5): -- To view, visit https://gerrit.ovirt.org/60999 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88008b26f340a87466e9fa98ffb34b5df7509390 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
