Adam Litke has posted comments on this change. Change subject: sampling: Retrieve backing chain stats ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/60888/1/lib/vdsm/virt/vmstats.py File lib/vdsm/virt/vmstats.py: PS1, Line 368: vol_uuid = os.path.basename(path) We usually avoid extracting information about a volume from its path. Virt code should treat the path as an opaque string so that storage is free to change the way we organize volumes on storage. Maybe we should provide a helper in hsm to convert a path to volUUID. -- To view, visit https://gerrit.ovirt.org/60888 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bbb8643d1c86e90d1e2de7cb2a5b00116c71453 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
