Martin Polednik has posted comments on this change. Change subject: hostdev: prefer numa nodes close to device MMIO ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/60640/4/vdsm/virt/vmxml.py File vdsm/virt/vmxml.py: PS4, Line 526: nodeset=utils.cpuset(set([dev_object.numa_node for dev_object in : devices if dev_object.numa_node]))) > This is wrong actually. NUMA only supports single preferred node. For the Or only prefer a node if we have all devices from the same group. -- To view, visit https://gerrit.ovirt.org/60640 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9bc795d2f5bad76ebf1e1bff391b3bc71037fffb Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
