Edward Haas has posted comments on this change. Change subject: ovs: rollback acquired ifaces after failure ......................................................................
Patch Set 5: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/61088/5/lib/vdsm/network/acquire.py File lib/vdsm/network/acquire.py: PS5, Line 49: _netinfo_nets I do not see why we need to keep this state in. Line 55: def __exit__(self, type, value, traceback): Line 56: if type is not None and self._acquired_ifcfgs: Line 57: for iface, ifcfg_lines in six.iteritems(self._acquired_ifcfgs): Line 58: _rollback_ifcfg_iface(iface, ifcfg_lines) Line 59: six.reraise(type, value, traceback) I'm pretty sure you do not need this reraise. Line 60: Line 61: def acquire_unowned_ifaces(self, external_ifaces): Line 62: """Acquire external ifaces which are not owned by us.""" Line 63: used_ports = frozenset(itertools.chain.from_iterable( https://gerrit.ovirt.org/#/c/61088/5/lib/vdsm/network/netswitch.py File lib/vdsm/network/netswitch.py: PS5, Line 159: a acquire_ctx ? We already have one char ('s') object, it is hard to see it now. -- To view, visit https://gerrit.ovirt.org/61088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b7a96c0a83e8dd5dbed1e83a16dd8de6428a601 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
