Adam Litke has posted comments on this change. Change subject: osutils: Start the osutils module ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/61142/4/tests/osutils_test.py File tests/osutils_test.py: Line 27: from testlib import forked Line 28: from vdsm.common import osutils Line 29: Line 30: Line 31: class TestCloseFd(VdsmTestCase): Can you also test the -EINTR case? Line 32: Line 33: # Run in a child process to ensure single thread. Otherwise another thread Line 34: # opening a file descriptor may cause false failure. Line 35: @forked -- To view, visit https://gerrit.ovirt.org/61142 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia995c083f31c3489ced16265d459f30355f854b0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
