Adam Litke has uploaded a new change for review.
Change subject: sdm: Wire up when_finished callback
......................................................................
sdm: Wire up when_finished callback
Change-Id: I8db3abc6e57a4a06b90ea1c7bb4186b0b936a152
Signed-off-by: Adam Litke <ali...@redhat.com>
---
M tests/storage_sdm_api_test.py
M vdsm/storage/sdm/api/base.py
2 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/55/61255/1
diff --git a/tests/storage_sdm_api_test.py b/tests/storage_sdm_api_test.py
index c8d93d2..a5f00bc 100644
--- a/tests/storage_sdm_api_test.py
+++ b/tests/storage_sdm_api_test.py
@@ -33,10 +33,16 @@
class ApiBaseTests(VdsmTestCase):
def run_job(self, job):
+ def finished_cb():
+ called[0] = True
+
+ called = [False]
+ job.when_finished(finished_cb)
self.assertEqual(jobs.STATUS.PENDING, job.status)
self.assertIsNone(getattr(vars, 'job_id', None))
job.run()
wait_for_job(job)
+ self.assertTrue(called[0])
self.assertIsNone(getattr(vars, 'job_id', None))
def test_states(self):
diff --git a/vdsm/storage/sdm/api/base.py b/vdsm/storage/sdm/api/base.py
index a342300..23603df 100644
--- a/vdsm/storage/sdm/api/base.py
+++ b/vdsm/storage/sdm/api/base.py
@@ -51,4 +51,5 @@
else:
self._status = jobs.STATUS.DONE
finally:
+ self._finished_cb()
vars.job_id = None
--
To view, visit https://gerrit.ovirt.org/61255
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8db3abc6e57a4a06b90ea1c7bb4186b0b936a152
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <ali...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
