Francesco Romani has posted comments on this change. Change subject: cmdutils: enhance systemd_run ......................................................................
Patch Set 24: (1 comment) https://gerrit.ovirt.org/#/c/56474/24/lib/vdsm/cmdutils.py File lib/vdsm/cmdutils.py: PS24, Line 80: if accounting: : command.extend([ : '--property=CPUAccounting=1', : '--property=MemoryAccounting=1', : '--property=BlockIOAccounting=1', : ]) > Do we expect to require all of these properties at once? Wouldn't having ac TL;DR: Yes: we need all of them, to mimic as closely as we can the bulk stats output. More context: We want to gather container metrics, and seems that everyone is just reading data from cgroupfs to do that. It is even a blessed way to go according to the docker technical blog. So we ask systemd to do some of the heavy lifting for us. Unfortunately, we can't (easily) use systemd tools to grab this information, so for the time being we will do the fetching ourselves. -- To view, visit https://gerrit.ovirt.org/56474 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id49be0d88d573958bf0884a254256bb2a745940a Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
