Nir Soffer has posted comments on this change. Change subject: Adding units to cpu metrics name according to metrics2.0 spec ......................................................................
Patch Set 3: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/62156/3/lib/vdsm/health.py File lib/vdsm/health.py: Line 126: report = {} Line 127: report[prefix + '.gc.uncollectable'] = \ Line 128: self._stats['uncollectable_obj'] Line 129: report[prefix + '.cpu.user_pct_s'] = self._stats['utime_pct'] Line 130: report[prefix + '.cpu.sys_pct_s'] = self._stats['stime_pct'] Both are *not* seconds but percent (0-100 * number of cpus), so they should not use _s. Line 131: report[prefix + '.memory.rss_m'] = self._stats['rss'] Line 132: report[prefix + '.threads_count'] = self._stats['threads'] Line 133: metrics.send(report) Line 134: https://gerrit.ovirt.org/#/c/62156/3/lib/vdsm/host/api.py File lib/vdsm/host/api.py: Line 104: Line 105: data[prefix + '.vms.active'] = hoststats['vmActive'] Line 106: data[prefix + '.vms.total'] = hoststats['vmCount'] Line 107: Line 108: data[prefix + '.cpu.load_5M'] = hoststats['cpuLoad'] 5M? Line 109: data[prefix + '.cpu.user_jiff'] = hoststats['cpuUser'] Line 110: data[prefix + '.cpu.sys_jiff'] = hoststats['cpuSys'] Line 111: data[prefix + '.cpu.idle_jiff'] = hoststats['cpuIdle'] Line 112: data[prefix + '.cpu.sys_vdsmd_jiff'] = hoststats['cpuSysVdsmd'] Line 105: data[prefix + '.vms.active'] = hoststats['vmActive'] Line 106: data[prefix + '.vms.total'] = hoststats['vmCount'] Line 107: Line 108: data[prefix + '.cpu.load_5M'] = hoststats['cpuLoad'] Line 109: data[prefix + '.cpu.user_jiff'] = hoststats['cpuUser'] Are you sure the values are in jiffies? Line 110: data[prefix + '.cpu.sys_jiff'] = hoststats['cpuSys'] Line 111: data[prefix + '.cpu.idle_jiff'] = hoststats['cpuIdle'] Line 112: data[prefix + '.cpu.sys_vdsmd_jiff'] = hoststats['cpuSysVdsmd'] Line 113: data[prefix + '.cpu.user_vdsmd_jiff'] = hoststats['cpuUserVdsmd'] -- To view, visit https://gerrit.ovirt.org/62156 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I366280bf1c3783fdbbdd7459e49ae7fcf5e8b598 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
