Yaniv Bronhaim has posted comments on this change. Change subject: Adding memTotal metric ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/62154/4/lib/vdsm/host/api.py File lib/vdsm/host/api.py: Line 93: data[storage_prefix + '.last_check'] = dom_info['lastCheck'] Line 94: Line 95: data[prefix + '.memory.available'] = hoststats['memAvailable'] Line 96: data[prefix + '.memory.committed'] = hoststats['memCommitted'] Line 97: data[prefix + '.memory.free_mb'] = hoststats['memFree'] > what is the _mb suffix here? its not related to the patch - see https://gerrit.ovirt.org/#/c/62155/4/lib/vdsm/host/api.py line 98 Line 98: data[prefix + '.memory.usage_percent'] = hoststats['memUsed'] Line 99: data[prefix + '.memory.total_M'] = hoststats['memTotal'] Line 100: data[prefix + '.memory.anon_huge_pages'] = hoststats['anonHugePages'] Line 101: -- To view, visit https://gerrit.ovirt.org/62154 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d3b237aa559f8b0ca835fb55c1205b2766c656a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yaniv Kaul <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
