Martin Polednik has posted comments on this change. Change subject: rng: allow urandom as virtio rng entropy source ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/59031/7/lib/vdsm/host/rngsources.py File lib/vdsm/host/rngsources.py: Line 34: return [ Line 35: source for (source, path) in _SOURCES.items() Line 36: if os.path.exists(path) and Line 37: # Remove when 4.0 is not supported. Line 38: source != 'urandom' > ok, but it isn't misleading to use a resource we don't list as available? T It is misleading, although it's availability is quite closely tied to "random" resource. I believe we have to add it ASAP (see the heated up discussion in https://bugzilla.redhat.com/show_bug.cgi?id=1074464). Line 39: ] Line 40: Line 41: Line 42: def get_device(name): -- To view, visit https://gerrit.ovirt.org/59031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jnied...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
