Dan Kenigsberg has submitted this change and it was merged. Change subject: compat: py3: capture output of CPopen.communicate ......................................................................
compat: py3: capture output of CPopen.communicate To allow better coverage of python3 testing, we use Popen instead of CPopen, as the latter is not implemented (and not needed) in python3. Unfortunately, CPopen has chosen to use stdout\err=subprocess.PIPE as its default. Now when cpopen supports stdout and strerr params we can always set those to PIPE to match the defaults. Change-Id: Iac9c1c1bd3ca1902103fac1f8675b7d42ca78a33 Signed-off-by: Dan Kenigsberg <dan...@redhat.com> Signed-off-by: Yaniv Bronhaim <ybron...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/61393 Continuous-Integration: Jenkins CI Reviewed-by: Piotr Kliczewski <piotr.kliczew...@gmail.com> Reviewed-by: Irit Goihman <igoih...@redhat.com> --- M lib/vdsm/commands.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Yaniv Bronhaim: Verified Jenkins CI: Passed CI tests Irit Goihman: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61393 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac9c1c1bd3ca1902103fac1f8675b7d42ca78a33 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Tomas Golembiovsky <tgole...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
