Edward Haas has posted comments on this change. Change subject: net: move name resolver functions from netinfo to ip ......................................................................
Patch Set 2: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/62704/2/lib/vdsm/network/ip/resolv.py File lib/vdsm/network/ip/resolv.py: Why the name change? Please convince us that the name needs to change. It's also a mix of two things: Relocating the module and changing its name. Line 1: # Line 2: # Copyright 2016 Red Hat, Inc. Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify PS2, Line 2: 2016 2015-2016 -- To view, visit https://gerrit.ovirt.org/62704 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc6732a4c0ab5aa6afd63b167834cc3942a62c15 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org