Francesco Romani has posted comments on this change. Change subject: virt: Initial support for post-copy migration ......................................................................
Patch Set 2: (3 comments) I'm obviously fine with the idea, and the general approach seems OK; I want to make sure we cover all sides, so few comments inside and -1 for visbility https://gerrit.ovirt.org/#/c/62873/2/vdsm/virt/migration.py File vdsm/virt/migration.py: PS2, Line 466: flags = (libvirt.VIR_MIGRATE_LIVE | : libvirt.VIR_MIGRATE_PEER2PEER | : (libvirt.VIR_MIGRATE_TUNNELLED if : self._tunneled else 0) | : (libvirt.VIR_MIGRATE_ABORT_ON_ERROR if : self._abortOnError else 0) | : (libvirt.VIR_MIGRATE_COMPRESSED if : self._compressed else 0) | : (libvirt.VIR_MIGRATE_AUTO_CONVERGE if : self._autoConverge else 0)) : if self._autoConverge: : try: : flags |= libvirt.VIR_MIGRATE_POSTCOPY : except AttributeError: : # Not present in libvirt < 1.3.3 : pass this code is begging for a cleanup, but I'll leave entirely to your good will :) Line 669: Line 670: now = time.time() Line 671: if self._in_post_copy: Line 672: self._vm.log.debug('Post-copy migration still in progress: %d', Line 673: progress.data_remaining) I guess this is the part on which we need data transfer from dest, right? Or is libvirt kind enough to let us have updated information on source side? Line 674: elif not self._use_conv_schedule and\ Line 675: (0 < migrationMaxTime < now - self._startTime): Line 676: self._vm.log.warn('The migration took %d seconds which is ' Line 677: 'exceeding the configured maximum time ' Line 691: ' > lowmark (%sMiB).' Line 692: ' Refer to RHBZ#919201.', Line 693: progress.data_remaining / Mbytes, lowmark / Mbytes) Line 694: Line 695: if not self._in_post_copy and\ so in post copy mode who's taking care of the convergence schedule? Line 696: lastDataRemaining is not None and\ Line 697: lastDataRemaining < progress.data_remaining: Line 698: iterationCount += 1 Line 699: self._vm.log.debug('new iteration detected: %i', -- To view, visit https://gerrit.ovirt.org/62873 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c9911f47331120a1b78326044a4949abf35d5fe Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
