Petr Horáček has posted comments on this change. Change subject: net: Adding bond api with sysfs driver under link ......................................................................
Patch Set 5: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/62828/1/lib/vdsm/network/link/bond.py File lib/vdsm/network/link/bond.py: Line 137: for key, value in options: Line 138: with open(self.BONDING_OPT % (self._master, key), 'w') as f: Line 139: f.write(value) Line 140: Line 141: def exists(self): > I'm not sure I understand what you are asking. In OVS if both slaves are dummies, we have no active slave. In legacy one of them is chosen (don't know how). Is it possible that even with linux bondings there will be no active slave? Line 142: return os.path.exists(self.BONDING_PATH % self._master) Line 143: Line 144: def active_slave(self): Line 145: with open(self.BONDING_ACTIVE_SLAVE % self._master) as f: https://gerrit.ovirt.org/#/c/62828/5/lib/vdsm/network/link/bond.py File lib/vdsm/network/link/bond.py: Line 132: f.write('-%s' % slave) Line 133: self._slaves.remove(slave) Line 134: Line 135: def set_options(self, options): Line 136: self._options.update(options) With this we are not going for result state. We must remove (or set to default) existing options. This will be tricky. Also we should update options one by one while setting. Line 137: for key, value in options: Line 138: with open(self.BONDING_OPT % (self._master, key), 'w') as f: Line 139: f.write(value) Line 140: -- To view, visit https://gerrit.ovirt.org/62828 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75f4f6b370f29411158e288610a1677b52998546 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
