Petr Horáček has posted comments on this change.

Change subject: net test: sourceroute thread crashes due to a test race
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/62995/1/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 1429:             self.vdsm_net.save_config()
Line 1430: 
Line 1431:             # Terminate the dhclient spawned by the setup to avoid a 
race
Line 1432:             # with the source route thread.
Line 1433:             dhclient.kill(client)
if this is a bug in VDSM, please add a temporary TODO.
Line 1434: 
Line 1435:             with dnsmasq_run(server, DHCP_RANGE_FROM, DHCP_RANGE_TO,
Line 1436:                              DHCPv6_RANGE_FROM, DHCPv6_RANGE_TO, 
IP_GATEWAY):
Line 1437:                 with namedTemporaryDir(dir='/var/lib/dhclient') as 
dhdir:


-- 
To view, visit https://gerrit.ovirt.org/62995
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f4db3b9dbd846c46c29af8ce097e9942609ce0e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Reply via email to