Dan Kenigsberg has posted comments on this change. Change subject: net: ifcfg - dhclient should always be stopped ......................................................................
Patch Set 8: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/62832/8/lib/vdsm/network/configurators/ifcfg.py File lib/vdsm/network/configurators/ifcfg.py: Line 531: # for static IP Line 532: cfg += 'BOOTPROTO=none\n' Line 533: elif ipv4.bootproto: Line 534: cfg += 'BOOTPROTO=%s\n' % pipes.quote(ipv4.bootproto) Line 535: this is horribly unrelated to creating a Conf File. Please add a big FIXME here (or in a followup patch) Line 536: if os.path.exists(os.path.join(NET_PATH, name)): Line 537: # Ask dhclient to stop any dhclient running for the device Line 538: dhclient.kill(name) Line 539: address.flush(name, family=4) -- To view, visit https://gerrit.ovirt.org/62832 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib60930670b335d02e3878743409fd2e5f4b3e26b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
