Dan Kenigsberg has posted comments on this change. Change subject: net func tests: Cleanup ifcfg files after each func test. ......................................................................
Patch Set 8: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/62833/8/tests/network/netfunctestlib.py File tests/network/netfunctestlib.py: Line 53: Line 54: NOCHK = {'connectivityCheck': False} Line 55: Line 56: IFCFG_DIR = '/etc/sysconfig/network-scripts/' Line 57: IFCFG_PREFIX = IFCFG_DIR + 'ifcfg-' we should name this just as NET_CONF_DIR NET_CONF_PREF or even import. Line 58: Line 59: Line 60: def requires_ipaddress(): Line 61: """ -- To view, visit https://gerrit.ovirt.org/62833 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c2757278bb5069aa5138af5c0897ced5f402367 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
