Nir Soffer has posted comments on this change. Change subject: draft: spec modification to pass koji build ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/63265/1/configure.ac File configure.ac: Line 247: AC_SUBST([vdsmbackupdir], ['${vdsmlogdir}/backup']) Line 248: AC_SUBST([vdsmexecdir], ['${libexecdir}/vdsm']) Line 249: AC_SUBST([vdsmhooksdir], ['${vdsmexecdir}/hooks']) Line 250: AC_SUBST([vdsmtsdir], ['${sysconfdir}/pki/vdsm']) Line 251: AC_SUBST([vdsmrepo], ['/var/run/vdsm/storage/repo']) > Man, please give options here at least... it doesn't help only to say that You can add a configuration --enable-filesystem-hierarchy-standard to move /rhev/data-center to /run/vdsm/data-center. We can enable this in the fedora build by default in contrib/koji-build.sh. The default must be "no" on both upstream and rhev, we will not support this location for now. It will not work because of selinux, we can open a fedora bug to fix selinux policy for vdsm - the policy should support both /rhev/data-center and /run/vdsm/data-center. We can remove /hrev/ from the selinux policy in future version. Line 252: AC_SUBST([vdsmpylibdir], ['${pythondir}/vdsm']) Line 253: AC_SUBST([vdsmnetinfodir], ['${vdsmpylibdir}/network/netinfo']) Line 254: AC_SUBST([vdsmtooldir], ['${vdsmpylibdir}/tool']) Line 255: AC_SUBST([configuratorsdir], ['${vdsmtooldir}/configurators']) -- To view, visit https://gerrit.ovirt.org/63265 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4dd839ace307fea0c7449cee173b9a26170ac0f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
