Yaniv Bronhaim has posted comments on this change.

Change subject: functional tests: fix supervdsmServer test
......................................................................


Patch Set 16:

(1 comment)

https://gerrit.ovirt.org/#/c/61902/16//COMMIT_MSG
Commit Message:

Line 9: supervdsmServer dropPrivileges function is switching root user to
Line 10: a non privileged user but not switching the user back to root. It 
causes
Line 11: other tests which require root user to fail.
Line 12: it's not possible to switch to root from non privileged user so
Line 13: every test is done in a seprate process so the user won't be changed
> It is possible to switch to root from non-privilege user, but you have to u
- we don't need that, you can change the commit msg

- although I thought you aim to elimate the usage of our own test utils, but as 
we already have those tools in our tree using @forked might be cool
Line 14: 
Line 15: Change-Id: I8c7e381809261cf330ef4f19c3fec5cd38254b1b


-- 
To view, visit https://gerrit.ovirt.org/61902
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c7e381809261cf330ef4f19c3fec5cd38254b1b
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Irit Goihman <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/admin/lists/[email protected]

Reply via email to