Allon Mureinik has posted comments on this change. Change subject: Live Merge: Refresh base volume before live merge ......................................................................
Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/63454/2//COMMIT_MSG Commit Message: PS2, Line 9: where the base volume format is RAW "to a RAW base volume" PS2, Line 10: there is a single snapshot This is not required - you can have an entire chain s4->s3->s2->s1->base and merge s1 into base. The other snapshots above it are inconsequential. https://gerrit.ovirt.org/#/c/63454/2/vdsm/virt/vm.py File vdsm/virt/vm.py: PS2, Line 4442: if drive.chunked and baseInfo['format'] == 'RAW': This will always refresh a raw volume. Should we also check that the sizes are different? -- To view, visit https://gerrit.ovirt.org/63454 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
