Nir Soffer has posted comments on this change. Change subject: upgrade: Support upgrade to v4 from v3 ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/63547/1/vdsm/storage/imageRepository/formatConverter.py File vdsm/storage/imageRepository/formatConverter.py: Line 343: log.debug("Switching the cluster lock for domain %s", domain.sdUUID) Line 344: domain._clusterLock = newClusterLock Line 345: Line 346: def v4DomainConverter(repoPath, hostId, domain, isMsd): Line 347: log = logging.getLogger('Storage.v4DomainConverter') This logger will never be released. Please use module level logger. In another patch, replace all the loggers in this module with module logger named "storage.format". Line 348: targetVersion = 4 Line 349: Line 350: if domain.getStorageType() in sd.BLOCK_DOMAIN_TYPES: Line 351: log.debug("Trying to upgrade domain %s to tag based metadata " Line 354: __convertDomainMetadataToTags(domain, targetVersion) Line 355: Line 356: else: Line 357: log.debug("Skipping the upgrade to tag based metadata version %s " Line 358: "for the domain %s", targetVersion, domain.sdUUID) Please use the happy path idiom: if domain.getStorageType() not in sd.BLOCK_DOMAIN_TYPES: log skipping domain... return log upgrading... upgrade... Line 359: Line 360: Line 361: _IMAGE_REPOSITORY_CONVERSION_TABLE = { Line 362: ('0', '2'): v2DomainConverter, -- To view, visit https://gerrit.ovirt.org/63547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a66346b91e49480d391116ba8ee8b8294f53ec4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
