Adam Litke has posted comments on this change. Change subject: Pass scheduler to jobs.start ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/62000/2/tests/jobsTests.py File tests/jobsTests.py: Line 63: class JobsTests(VdsmTestCase): Line 64: TIMEOUT = 1 Line 65: Line 66: def setUp(self): Line 67: scheduler = schedule.Scheduler() > I would not create a real scheduler, this will make it much harder to test Done Line 68: jobs.start(scheduler) Line 69: Line 70: def tearDown(self): Line 71: jobs.stop() -- To view, visit https://gerrit.ovirt.org/62000 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5004b49b992ae0f7171a0f0549465cc8782d05da Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org