Roy Golan has posted comments on this change. Change subject: storage: add more info to NFS SD getInfo ......................................................................
Patch Set 1: (1 comment) - can this reveal secure info of some sort? - Thinking on the client side, the engine should consume that and possibly store that as the mount option on that domain and obviously not all the info is relevant. Maor, Liron how do you see this? https://gerrit.ovirt.org/#/c/63636/1/vdsm/storage/nfsSD.py File vdsm/storage/nfsSD.py: Line 131: try: Line 132: mntrcd = mount.getMountFromTarget(self.mountpoint).getRecord() Line 133: info['vfsType'] = mntrcd.fs_vfstype Line 134: info['mountOptions'] = mntrcd.fs_mntops Line 135: except mount.MountError: log the err? Line 136: return info Line 137: Line 138: return info Line 139: -- To view, visit https://gerrit.ovirt.org/63636 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id54d735a43871f94684e94395b1569c54c03e8ce Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Fred Rolland <froll...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
