Dan Kenigsberg has submitted this change and it was merged. Change subject: rng: allow urandom as virtio rng entropy source ......................................................................
rng: allow urandom as virtio rng entropy source Libvirt previously used a whitelist to only allow random and hwrng virtio-rng sources. As per libvirt commit 67f2b72723c242969c5282fcb9acf00cc01f2a54, this restriction is lifted and any character device may be used. We don't exactly want to use *any* character device, but we may allow usage of urandom. Additional discussion in RHBZ#1074464. The implementation hides the fact that urandom can be used. This is due to the fact that 4.0 (and lower) engine can't handle additional RNG sources. Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1347669 Signed-off-by: Martin Polednik <mpoled...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/59031 Continuous-Integration: Jenkins CI Reviewed-by: Milan Zamazal <mzama...@redhat.com> Reviewed-by: Dan Kenigsberg <dan...@redhat.com> --- M lib/vdsm/host/rngsources.py M tests/rngsources_test.py 2 files changed, 6 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Martin Polednik: Verified Milan Zamazal: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jnied...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
