Edward Haas has posted comments on this change. Change subject: build net tests: Create a test target for networking tests. ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/63649/2//COMMIT_MSG Commit Message: PS2, Line 9: networking > What do you think about providing generic mechanism for other verticals to That would be great. Do you have a specific suggestion? Splitting the tests into local variables and preparing for each its own target, is a good start. Then we can continue and move each group to its folder (or just do it as part of the previous step). Then we can move the test run to the individual folder, so each can hack it without affecting other verticals and eventually allowing splitting the vertical from the mother ship. https://gerrit.ovirt.org/#/c/63649/2/tests/Makefile.am File tests/Makefile.am: Line 375: @true Line 376: Line 377: check-net: Line 378: @echo '*** Running networking tests. ***' Line 379: @$(top_srcdir)/tests/run_tests_local.sh $(args) $(network_modules) > is it possible to run functional tests via run_tests_local? No, and it does not belong in here. Makefiles are for the building part which usually includes everything until installation, including tests that do not need the app running. Line 380: Line 381: # crossImportsTests.py has to be run separate due to different tests which Line 382: # load modules first, making the env dirty. Unloading python modules Line 383: # is not supported, see http://bugs.python.org/issue9072 . -- To view, visit https://gerrit.ovirt.org/63649 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e417ae67958eac24e8fb11a44057dd0e524d3fa Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Irit Goihman <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
