Piotr Kliczewski has posted comments on this change. Change subject: vdsm: Rely on system for logrotation ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/63682/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2016-09-11 13:33:20 +0200 Line 6: Line 7: vdsm: Rely on system for logrotation Line 8: Line 9: When logrotate is installed it is normaly run periodicaly by cron. There I am missing value of this change here. Why do we want to do it? Line 10: is no real reason to invoke logrotate manualy. Line 11: Line 12: Also if we rely on system to run logrotate we can remove the dependency Line 13: on it from RPMs. It is enough to install the configuration file into the Line 10: is no real reason to invoke logrotate manualy. Line 11: Line 12: Also if we rely on system to run logrotate we can remove the dependency Line 13: on it from RPMs. It is enough to install the configuration file into the Line 14: the directory with logrotate configuration. > What if logrotate is not installed on the system? Based on spec change in line 134 it was installed with vdsm. Line 15: Line 16: The patch also renames script vdsm-logrotate to vdsm-remove-logs because Line 17: it doesn't run logrotate anymore. It only removes old log files. Line 18: -- To view, visit https://gerrit.ovirt.org/63682 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica888244bd7c65121f55983e5716a6eae5662879 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky <tgole...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org