Francesco Romani has posted comments on this change. Change subject: lib: api.py: preserve signature in decorator ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/63759/7/lib/vdsm/common/api.py File lib/vdsm/common/api.py: Line 29: Line 30: _log = logging.getLogger("virt.api") Line 31: Line 32: Line 33: @decorator > I didn't though about performance, but will check the numbers, now I'm curi The microbenchmark (https://gerrit.ovirt.org/63833) doesn't look too good: decorator method speed penalty: with just functools.wraps: 0.00645804405212 with the decorator module: 0.0969560146332 Line 34: def method(func, *args, **kwargs): Line 35: """ Line 36: Decorate an instance method, and return a response according to the Line 37: outcome of the call. -- To view, visit https://gerrit.ovirt.org/63759 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06205cf180229ea19ffc38a7b88346afc18f13e4 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org