Nir Soffer has posted comments on this change. Change subject: jobs: Autodelete ......................................................................
Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/62002/8/lib/vdsm/jobs.py File lib/vdsm/jobs.py: Line 117 Line 118 Line 119 Line 120 Line 121 Please add a comment that we must not autodelete a job if _abort() failed. Otherwise I see the patch adding dangerous try-finally here to make sure we auto delete the job :-) -- To view, visit https://gerrit.ovirt.org/62002 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4aafd2271397bd9bc4289dc1aab723398d475add Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
