Nir Soffer has uploaded a new change for review.

Change subject: build: Disable tests during build
......................................................................

build: Disable tests during build

Tests are needed for development, not for building a package. This
allows us to use latest and greatest development tools, which are not
available in brew or koji.

Since we install nose using pip, remove the build requires - we don't
need now nose to build rpms.

Change-Id: I9e3589c365166f934f117b53c65cea4b90db3516
Signed-off-by: Nir Soffer <nsof...@redhat.com>
---
M vdsm.spec.in
1 file changed, 0 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/63966/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index f234b09..c7f6dde 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -62,7 +62,6 @@
 BuildRequires: python2-devel
 BuildRequires: python-mock
 BuildRequires: python-netaddr
-BuildRequires: python-nose
 BuildRequires: python-six >= 1.9.0
 BuildRequires: rpm-build
 
@@ -95,10 +94,8 @@
 
 %if 0%{?with_python3}
 %if 0%{?rhel}
-BuildRequires: python34-nose
 BuildRequires: python34-six
 %else # fedora
-BuildRequires: python3-nose
 BuildRequires: python3-six
 BuildRequires: python3-netaddr
 BuildRequires: python3-yaml
@@ -781,9 +778,6 @@
 # Install the libvirt hook for cleaning up the XML
 install -Dm 0755 vdsm/virt/libvirt-hook.sh \
                  %{buildroot}%{_sysconfdir}/libvirt/hooks/qemu
-
-%check
-make tests
 
 %pre
 # Force standard locale behavior (English)


-- 
To view, visit https://gerrit.ovirt.org/63966
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9e3589c365166f934f117b53c65cea4b90db3516
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Reply via email to