Hello Francesco Romani, Milan Zamazal,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/63972

to review the following change.

Change subject: virt: Pass missing parameter on desktopLogoff
......................................................................

virt: Pass missing parameter on desktopLogoff

Previously this parameter was not passed and all seemed
fine from the logs, but it actually wasn't the exception
was swallow that the parameter was missing.
The parameter is actually not used, but still mandatory.

Change-Id: I65b030d4a7a7ed7ad3f6279c66120d1f9e45d396
Backport-To: 4.0
Bug-Url: https://bugzilla.redhat.com/1349383
Bug-Url: https://bugzilla.redhat.com/1371264
Signed-off-by: Vinzenz Feenstra <vfeen...@redhat.com>
Reviewed-on: https://gerrit.ovirt.org/59866
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani <from...@redhat.com>
Reviewed-by: Milan Zamazal <mzama...@redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/72/63972/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index f50aa16..61e8957 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -894,7 +894,7 @@
             if self._consoleDisconnectAction == CDA.LOCK_SCREEN:
                 self.guestAgent.desktopLock()
             elif self._consoleDisconnectAction == CDA.LOGOUT:
-                self.guestAgent.desktopLogoff()
+                self.guestAgent.desktopLogoff(False)
             elif self._consoleDisconnectAction == CDA.REBOOT:
                 self.shutdown(delay=delay, reboot=True, timeout=timeout,
                               message='Scheduled reboot on disconnect',


-- 
To view, visit https://gerrit.ovirt.org/63972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I65b030d4a7a7ed7ad3f6279c66120d1f9e45d396
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Reply via email to