Michal Skrivanek has posted comments on this change.

Change subject: vm: avoid mark unresponsive on startup
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/63008/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 514: 
Line 515:         self.saveState()
Line 516:         self._vmStartEvent.set()
Line 517:         try:
Line 518:             sampling.stats_cache.add(self.id)
won't it caue monitoring errors before the VM is running?
Line 519:             self.memCommit()
Line 520:             with self._ongoingCreations:
Line 521:                 self._vmCreationEvent.set()
Line 522:                 try:


-- 
To view, visit https://gerrit.ovirt.org/63008
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieff034814d5cda4414052349a0a403b8dcea7a0b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Reply via email to