Shahar Havivi has posted comments on this change.

Change subject: v2v: Support for ova exported from AWS
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/63517/2/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:

Line 1187:     vmName = node.find('./ovf:VirtualSystem/ovf:Name', ns)
Line 1188:     if vmName is not None:
Line 1189:         vm['vmName'] = vmName.text
Line 1190:     else:
Line 1191:         vm['vmName'] = 'default'
> perhaps the id? vm-id?
we don't have an id...
we can use the ova file name as a name...
Line 1192: 
Line 1193:     memSize = node.find('.//ovf:Item[rasd:ResourceType="%d"]/'
Line 1194:                         'rasd:VirtualQuantity' % 
_OVF_RESOURCE_MEMORY, ns)
Line 1195:     if memSize is not None:


-- 
To view, visit https://gerrit.ovirt.org/63517
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6215491cb724c2131d440b00e767a5690070a7b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Tomas Golembiovsky <tgole...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Reply via email to