Dan Kenigsberg has posted comments on this change. Change subject: network: switch to concurrent.thread() ......................................................................
Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/61459/13//COMMIT_MSG Commit Message: Line 9: This patch: Line 10: 1. replaces good usages of threading.Thread() with Line 11: more modern concurrent.thread() Line 12: 2. replaces bad usages of threading.Thread() - inheritance Line 13: with composition, leveraging concurrent.thread() > the commit message seems stale - I see no inheritance removed by this patch (02:37:20 PM) fromani: copy/paste sin! Line 14: Line 15: there are no intended changes in behaviour. Line 16: Line 17: Change-Id: Ie7918a6762b35000b02187a0356273e40bba57a8 -- To view, visit https://gerrit.ovirt.org/61459 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7918a6762b35000b02187a0356273e40bba57a8 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
