Piotr Kliczewski has posted comments on this change.

Change subject: stomp: make client user aware that no connection available
......................................................................


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/58029/8/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:

Line 399:     def send(self, message, 
destination=stomp.LEGACY_SUBSCRIPTION_ID_RESPONSE,
Line 400:              headers=None):
Line 401:         self.log.debug("Sending response")
Line 402: 
Line 403:         if not self._stompConn.is_closed():
> if not? Seems that this should be:
Done
Line 404:             raise stomp.Disconnected()
Line 405: 
Line 406:         self._aclient.send(
Line 407:             destination,


-- 
To view, visit https://gerrit.ovirt.org/58029
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c0a2b2df9ac6e9f6e75a8af0f0f3a36990c2462
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to