Adam Litke has posted comments on this change.

Change subject: ResourceManagerLock: Disable autoRelease
......................................................................


Patch Set 1:

Dan: acquire is always used as a context manager which means the reference to 
the resource is maintained throughout the context.  When using the code as a 
regular function (the resourceManager code was supposedly designed to allow 
both forms) you have to either artificially maintain the reference or disable 
autorelease in order to avoid this 'magic' behavior.

-- 
To view, visit https://gerrit.ovirt.org/63967
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie70dca0079f773362bfebe6b9a08677c94314e68
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smela...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to