Nir Soffer has posted comments on this change.

Change subject: tests: Run mount tests multiple times
......................................................................


Patch Set 7: Verified-1

(1 comment)

-1 to prevent accidental merge

https://gerrit.ovirt.org/#/c/56545/7/tests/mountTests.py
File tests/mountTests.py:

Line 122: 
Line 123: @expandPermutations
Line 124: class MountTests(TestCaseBase):
Line 125: 
Line 126:     @permutations([["%03d" % i] for i in range(500)])
> doesn't this make it a @slowtest? why abuse permutation instead of adding a
This is only for testing the previous patch, not for merging to master.

Using for require bigger change (indenting entire body), fails on the first 
failure, and does not give the nice output as permutations.
Line 127:     @ValidateRunningAsRoot
Line 128:     def testLoopMount(self, _):
Line 129:         with namedTemporaryDir() as mpath:
Line 130:             # two nested with blocks to be python 2.6 friendly


-- 
To view, visit https://gerrit.ovirt.org/56545
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idaed2e8e1c5b2bd04c412233d94e94005c23189c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Idan Shaby <ish...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to