Edward Haas has posted comments on this change.

Change subject: net: Use Linux bonds with OVS networks
......................................................................


Patch Set 26:

(2 comments)

https://gerrit.ovirt.org/#/c/63119/25/lib/vdsm/network/ovs/switch.py
File lib/vdsm/network/ovs/switch.py:

Line 34: BRIDGE_PREFIX = 'vdsmbr_'
Line 35: 
Line 36: 
Line 37: def validate_network_setup(nets, bonds):
Line 38:     _netinfo = get_netinfo()
Why this change is needed?
Line 39:     ovs_netinfo = info.create_netinfo(info.OvsInfo())
Line 40:     for net, attrs in six.iteritems(nets):
Line 41:         validator.validate_net_configuration(
Line 42:             net, attrs, bonds, _netinfo['bondings'], _netinfo['nics'])


https://gerrit.ovirt.org/#/c/63119/24/lib/vdsm/network/ovs/validator.py
File lib/vdsm/network/ovs/validator.py:

PS24, Line 79:                 remove_nets_with_bond.add(net)
             :             if attrs.get('bonding') == bond:
             :                 add_nets_with_bond.add(net)
             :         else:
Why have you removed this check?


-- 
To view, visit https://gerrit.ovirt.org/63119
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6aeff335949a6e2996f7c3faa524df784dff1b01
Gerrit-PatchSet: 26
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to