Shahar Havivi has posted comments on this change.

Change subject: v2v: add test for Xen block device
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/63022/3/tests/v2vTests.py
File tests/v2vTests.py:

Line 533:             vms = v2v.get_external_vms(self.xen_url, 'user',
Line 534:                                        ProtectedPassword('password'),
Line 535:                                        None)['vmList']
Line 536: 
Line 537:         self.assertEqual(len(vms), len(VM_SPECS) - 1)
> please check that the missing VM is the one you set the disk type as block.
Done
Line 538: 
Line 539:     @MonkeyPatch(v2v, '_VIRT_V2V', FAKE_VIRT_V2V)
Line 540:     @MonkeyPatch(v2v, '_LOG_DIR', None)
Line 541:     def testSuccessfulImportOVA(self):


-- 
To view, visit https://gerrit.ovirt.org/63022
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1afc7d21857e59ebf69856e99e15cc3796149e4e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Tomas Golembiovsky <tgole...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to