Nir Soffer has posted comments on this change. Change subject: formatConverter: Adding comment for format converter class. ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/64098/1/vdsm/storage/imageRepository/formatConverter.py File vdsm/storage/imageRepository/formatConverter.py: Line 366: # a 4.1 Data Center should be supported only with V4 storage domains. Line 367: # Line 368: # Version 4 should eventualy reflect support for old and new Line 369: # qcow formats, 0.10 and 1.1. Line 370: # We need a module docstring - just bellow the copyright notice. Please use this format: """ module name - short description Few lines about this module... Supported storage formats - don't waste time on formats 0, 2, and 3. How format 4 is different from older formats... """ Line 371: class FormatConverter(object): Line 372: def __init__(self, conversionTable): Line 373: self._convTable = conversionTable Line 374: -- To view, visit https://gerrit.ovirt.org/64098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied39b62d98691f185525f7821ef6fd1c63f42f40 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
