Yaniv Bronhaim has posted comments on this change.

Change subject: vdsClient: Configure logging before imports
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/64099/2//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: vdsClient: Configure logging before imports
Line 8: 
Line 9: Because vdscli logs devel warning on import, we get this unwanted
Line 10: error from the logging module:
please rebase over https://gerrit.ovirt.org/#/c/62209/ if its part of it
Line 11: 
Line 12:    No handlers could be found for logger "devel"
Line 13: 
Line 14: Configuring logging avoids this error.


https://gerrit.ovirt.org/#/c/64099/2/client/vdsClient.py
File client/vdsClient.py:

Line 28: import re
Line 29: import shlex
Line 30: import socket
Line 31: import pprint as pp
Line 32: import logging
> Since imports are not sorted, we cannot add logging in the correct place.
please sort it and rebase
Line 33: 
Line 34: from six.moves import xmlrpc_client
Line 35: 
Line 36: # Must configure logging before importing vdsm modules, some modules 
may log


-- 
To view, visit https://gerrit.ovirt.org/64099
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib08c8908997becd948693a33df02c3240d3dcc6b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to