Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm: Do not modify warnings filter in a library
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/64100/1//COMMIT_MSG
Commit Message:

Line 13: 
Line 14: This warnings is highly unwanted, causing user facing warnings each 
time
Line 15: you run a vdsClient or hosted-engine command.
Line 16: 
Line 17: This patch remove the wrong filter, returning control to the 
application
s/remove/removes
Line 18: using vdscli. Since warnings hare hidden by default, this remove the
Line 19: unwanted warnings from vdsClient and hosted-engine command line tools.
Line 20: 
Line 21: Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77


Line 14: This warnings is highly unwanted, causing user facing warnings each 
time
Line 15: you run a vdsClient or hosted-engine command.
Line 16: 
Line 17: This patch remove the wrong filter, returning control to the 
application
Line 18: using vdscli. Since warnings hare hidden by default, this remove the
s/hare/are s/remove/removes
Line 19: unwanted warnings from vdsClient and hosted-engine command line tools.
Line 20: 
Line 21: Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Line 22: Bug-Url: https://bugzilla.redhat.com/1377069


Line 15: you run a vdsClient or hosted-engine command.
Line 16: 
Line 17: This patch remove the wrong filter, returning control to the 
application
Line 18: using vdscli. Since warnings hare hidden by default, this remove the
Line 19: unwanted warnings from vdsClient and hosted-engine command line tools.
Maintainers' conflict? Dan wanted it that way exactly. I guess this warning has 
a purpose and the purpose was achieved. I susgest to focus about removing the 
usages and with that also the warning will disappear
Line 20: 
Line 21: Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Line 22: Bug-Url: https://bugzilla.redhat.com/1377069


-- 
To view, visit https://gerrit.ovirt.org/64100
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to