Yaniv Bronhaim has posted comments on this change. Change subject: tests: Mark integration tests ......................................................................
Patch Set 6: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/55730/6//COMMIT_MSG Commit Message: Line 9: Mark tests that test the environment and not vdsm code as integration Line 10: tests. This skip the tests in make check and prevent failures on travis Line 11: and jenkins. Line 12: Line 13: Integration tests should run separately in a special environment, not can you elaborate what "special environment" means? Line 14: during regular make check. Line 15: Line 16: These tests still fail on travis: Line 17: Line 20: Line 21: utilsTests.CommandPathTests Line 22: testExistingNotInPaths FAIL Line 23: Line 24: I marked these tests as @brokentest for now, will look into them later. please separate it from the "mark integration tests" idea Line 25: Line 26: Note: outOutProcessTests fail because ioprocess is not installed in the Line 27: docker image. This must be fixed in the image. Line 28: Line 23: Line 24: I marked these tests as @brokentest for now, will look into them later. Line 25: Line 26: Note: outOutProcessTests fail because ioprocess is not installed in the Line 27: docker image. This must be fixed in the image. just add it to contrib/Dockerfile - there is no need to mention it here Line 28: Line 29: Change-Id: I056dc7534bde94a157e750f6699db4fe6a3aff27 -- To view, visit https://gerrit.ovirt.org/55730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I056dc7534bde94a157e750f6699db4fe6a3aff27 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
