Martin Sivák has posted comments on this change.

Change subject: vdscli: do not use the warnings module
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/64117/1/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:

PS1, Line 40: "devel"
Nir is right that the logger will cause issues in projects importing the lib. 
1) it will be not configured 2) the name is too generic for a library


PS1, Line 40: _devel
I still have an issue with the name :) Use log_devel or something more readable.


-- 
To view, visit https://gerrit.ovirt.org/64117
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3481538292cf1a77329faf3d7701767b6e0bfd60
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Reply via email to